chore: Initial repo preparation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentleyvk
requested review from
veekeys,
mayank99,
FlyersPh9 and
gretanausedaite
mayank99
reviewed
Jan 28, 2022
packages/layouts-css/package.json
Outdated
| "itwin" | ||
| ], | ||
| "dependencies": { | ||
| "@itwin/itwinui-css": "^0.44.2" |
There was a problem hiding this comment.
I'm thinking. This is a weird situation as it goes against the new recommendations (https://github.com/iTwin/iTwinUI-react/wiki/Version-conflicts) but it's also a CSS repo
There was a problem hiding this comment.
Maybe it is finally time to release iTwinui-css v1 😀
There was a problem hiding this comment.
I dont think our CSS is ready for v1. But we should move the variables into a different repo that is v1
veekeys
reviewed
Jan 31, 2022
veekeys
reviewed
Jan 31, 2022
veekeys
reviewed
Jan 31, 2022
veekeys
reviewed
Jan 31, 2022
veekeys
reviewed
Jan 31, 2022
packages/layouts-react/src/components/PageLayout/PageLayout.tsx
Outdated
Show resolved
Hide resolved
veekeys
reviewed
Jan 31, 2022
veekeys
approved these changes
Feb 1, 2022
mayank99
approved these changes
Feb 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./packagesfolder, demo app is in./demo.styles.css,stylelint,eslintandprettieris configured.Sandpackfor code highlighting but we are not using all stuff from it and it is pretty heavy so would need to find a replacement (likereact-syntax-highlighter). Currently demo code is automatically added toSandpackbut it is not ideal, may need to just add everything manually.