Reconfigure Test Command #1898
Merged
Reconfigure Test Command #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamMeza-Bentley
force-pushed
the
Adam-Meza/test-all-config
branch
from
876893e
to
6c4ba33
Compare
AdamMeza-Bentley
requested review from
rohan-kadkol and
Ben-Pusey-Bentley
and removed request for
a team
…iTwinUI into Adam-Meza/test-all-config
|
All functionality is working on my machine, as well as in the dev container. |
mayank99
reviewed
Mar 27, 2024
mayank99
reviewed
Mar 28, 2024
mayank99
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Running each test for any one given component took longer than desired and required four long commands, two of which needed to be run in particular folders. This PR solves that problem by reconfiguring the
testcommand. Nowtestwill serve three use cases:teststill runs all teststest --filter=[filter]runs specific tests when a--filteris found in the argumentstest [compName]e.g.pnpm test Alertwill run all tests for the Alert ComponentQuirks/Issues
Due to our use of
concurrentlyall processes must be aborted individually. This is an issue that was recently addressed. Not sure when/how we can use this update. I opted not to update any dependencies to keep the scope of this PR relatively small.Testing
I've tested these changes by running
teston a number of components. I made sure to test working and broken tests to ensure that errors are caught when thrown.Docs
I've added a section on this command inside of
CONTRIBUTING.mdto demonstrate use.