Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaces monthShort format for 'de' locale #1694

Closed

Conversation

codeadventurer
Copy link

de locale abbreviations for monthsShort differ from Moment.js since a dot is missing at the end of months with more than 4 letters.

This PR fixes monthShort format for de locale.

See issue #1693

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1694 (84f96f3) into dev (b5a1391) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1694   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines         1996      1996           
  Branches       507       507           
=========================================
  Hits          1996      1996           
Impacted Files Coverage Δ
src/locale/de.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a1391...84f96f3. Read the comment docs.

@codeadventurer codeadventurer changed the title Replaces monthShort format for 'de' locale fix: replaces monthShort format for 'de' locale Nov 12, 2021
@idc77
Copy link

idc77 commented Nov 26, 2021

@codeadventurer
Copy link
Author

@iamkun When could it be merged? It's currently blocking migration from moment.js to day.js in my company :/

@samhoogantink
Copy link

@codeadventurer This has been fixed in #1746 if I'm right

@codeadventurer
Copy link
Author

Apparently fixed in other PR

@codeadventurer codeadventurer deleted the fixes/de_locale_months_short branch January 12, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants