Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: BREAKING CHANGE remove airbnb deps #201

Closed
wants to merge 1 commit into from

Conversation

nilzona
Copy link

@nilzona nilzona commented Feb 19, 2021

To be able to have a cleaner setup we would let the user choose which of airbnb/airbnb-base that should be decorated. This PR removes unnecessary dependencies and warnings if you want to use the base variant.

So we would let the user install either eslint-config-airbnb or eslint-config-airbnb-base together with the peer dependencies and then the eslint config would be as follows:

module.exports = {
  extends: ['airbnb', 'airbnb-typescript'],
};

or for base

module.exports = {
  extends: ['airbnb-base', 'airbnb-typescript/base'],
};

This fixes #6

To be able to have a cleaner setup we would let the user choose which of `airbnb`/`airbnb-base` that should be decorated. This commit removes unnecessary dependencies and warnings if you want to use the base variant.
@robertsonjoe
Copy link

This should be merged in, fixed the issue I was having.

thanks @nilzona

@nilzona
Copy link
Author

nilzona commented Apr 28, 2021

doesn't seem like this is going to be merged or considered.
@iamturns I turned my fork of this project into a monorepo where both typescript flavors of airbnb and airbnb-base are being released as separate packages. I remember seeing a comment from you that you would like to do that here also. Depending on how you do it, it could be breaking the current airbnb-base users, but the normal airbnb use case would not be breaking. If you want I can submit a PR with that approach instead?

@nilzona nilzona closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got npm install Warnings When Use eslint-config-airbnb-base
2 participants