Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove references to deprecated camelcase rule #97

Closed
wants to merge 1 commit into from
Closed

fix: remove references to deprecated camelcase rule #97

wants to merge 1 commit into from

Conversation

bbeesley
Copy link

Typescript eslint camelcase rule has now been removed in favour of the new naming-convention rule.
This change removes the reference to camelcase and replaces it with an equivalent naming-convention
rule.

fix #95

Typescript eslint camelcase rule has now been removed in favour of the new naming-convention rule.
This change removes the reference to camelcase and replaces it with an equivalent naming-convention
rule.

fix #95
@bbeesley
Copy link
Author

@iamturns lmk if there's anything you need me to amend here

@David-Else
Copy link

@iamturns I looked at the time it has taken in the past to update the Airbnb config on a major new ESLint airbnb/javascript#2223 and it can be months. Please merge this commit unless there is an objection. Thanks!

@bbeesley
Copy link
Author

bbeesley commented Jun 2, 2020

To be honest, I've been trying it out in another project and I can't exactly match the original camelcase rule, so it isn't going to be 100% compatible.

@David-Else
Copy link

@bbeesley Personally I don't care how accurate it is to the original, I would just like to get my lint setup running again without having to manually remove @typescript-eslint/camelcase

@iamturns
Copy link
Owner

iamturns commented Jun 2, 2020

Hey @bbeesley - thanks for the PR! I've started reviewing this evening, and your hunch is correct - I think there's more nuance we need to capture in the settings. As an example, this PR enforces camelCase on properties, which is something Airbnb specifically disables.
I've been scanning the Airbnb style guide and experimenting with different settings for @typescript-eslint/naming-convention. Getting closer, but I need to sign off for the evening. Will continue soon. Thanks again for the PR 👍

@iamturns
Copy link
Owner

iamturns commented Jun 3, 2020

Hey @bbeesley - have implemented this change in PR #99 . It required some different settings, and also disabling some other rules too.

Released as v8.0.0 now.

Thanks again for this PR which kicked this change forward 👏

@bbeesley bbeesley closed this Jun 3, 2020
@bbeesley bbeesley deleted the remove-camelcase-ref branch June 3, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to use typescript-eslint v3.0.0
3 participants