Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event trigger #10

Open
wants to merge 6 commits into
base: button
Choose a base branch
from

Conversation

sannecottaar
Copy link

'Finger touch events' are triggered by cursor movements, this filter fixes that when using a mouse , but has not been tested with a touch screen.

Just had to go through the install instructions on my new mac, so fixed those as well.

@ian-r-rose
Copy link
Owner

Hmm, this breaks the finger interactions on my touch screen. That is to say, on my device, the button branch works correctly for both finger events and mouse events. Unfortunately, I suspect that the precise events that we need to filter for will depend a bit on the touch screen device.

Ultimately, I think that the way to go is to get this branch to a state so that it has all the functionality that you need, and then we can create separate branches that have the correct touch behavior for a given device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants