Do not move selection outside inline node when composition starts #5541
+8
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e3a9c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I can't reproduce this Netlify build failure. https://app.netlify.com/sites/slatejs/deploys/653c11a6be7e130008cadad1 |
|
@dylans It looks like the Netlify failure was a one-off. Now it's just the Playwright failures we've been seeing on all PRs lately. Can we get this merged? |
1 task
|
@dylans |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes logic that moves selection outside inline node when composition starts. I'm not 100% sure removing this behaviour is a good idea, but it seems necessary to preserve behaviour parity between IME and non-IME text insertion. See the linked issue for more info.
Issue
Fixes: #5540
Example
Old:
https://github.com/ianstormtaylor/slate/assets/4272090/6396943f-9167-41b1-99f4-e59b552d3738
New:
https://github.com/ianstormtaylor/slate/assets/4272090/b209abc6-4720-4913-9cc6-1711e3a02004
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)