Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize Schema Composition Errors #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

comp615
Copy link
Contributor

@comp615 comp615 commented Apr 21, 2023

Description of changes
Changes the logic a bit so that we also allow for the possibility of a build failure before we early exit when alwaysComment is false

Fixes #32

Checklist

  • Have you fully tested your PR locally?
  • Have you written thorough tests for your work?
  • Have you made a CHANGELOG entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composition / Invalid Schema Errors are incorrectly shown as passes
1 participant