Treat prepublish as publish; preinstall as install #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff as requested in discussion on iarna#10. Not sure it'll work for all use cases, but it works for mine, so I've quietly forked it until `npm@4` comes along and straightens this mess out for everyone.
iarna
reviewed
Jan 7, 2017
| @@ -11,6 +11,7 @@ function inCommand (cmd) { | |||
| if (!npm_config_argv.cooked instanceof Array) process.exit(1) | |||
|
|
|||
| var V | |||
| if (npm_config_argv.cooked[0] === 'run') npm_config_argv.cooked.shift() | |||
There was a problem hiding this comment.
You're strippping the first argument if it's run but I don't get what problem you're solving?
It looks like you're trying to make npm run prepublish be detectable? Why?
There was a problem hiding this comment.
Per #10, lerna bootstrap runs npm prepublish in each package directory to get it ready for a symlink from one of its dependencies.
Ronald1M
approved these changes
Sep 18, 2018
|
Fixes #1 |
|
Should we consider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff as requested in discussion on #10. Not sure it'll work for all use cases, but it works for mine, so I've quietly forked it until
npm@4comes along and straightens this mess out for everyone.Not ready for acceptance by a long shot: