feat: support UUIDs to pyarrow on more backends #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
NickCrews
force-pushed
the
uuid-to-pyarrow
branch
5 times, most recently
from
2d5361f
to
bb2087d
Compare
NickCrews
changed the title
NickCrews
force-pushed
the
uuid-to-pyarrow
branch
3 times, most recently
from
accada4
to
b853a19
Compare
NickCrews
force-pushed
the
uuid-to-pyarrow
branch
from
b853a19
to
dae0350
Compare
NickCrews
commented
May 12, 2024
| cls, column: pa.Array | pd.Series, dtype: dt.DataType | ||
| ) -> pa.Array: | ||
| if isinstance(column, pd.Series): | ||
| if dtype.is_uuid(): |
There was a problem hiding this comment.
I don't love this special casing here. we could do doing something like
target_pd_type = PandasType.from_ibis(PyarrowType.to_ibis(PyarrowType.from_ibis(dtype)))
which would eval to
PandasType.from_ibis(PyarrowType.to_ibis(PyarrowType.from_ibis(dt.UUID)))
PandasType.from_ibis(PyarrowType.to_ibis(pa.string))
PandasType.from_ibis(dt.String)
pd.StringType
but IDK that is a bit of a brainf$#$%k as well.
IDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes #8902.
Implements UUID execution to pyarrow on some backends, and adds notimpl tests for the rest.