Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix ArrayValue.remove() handling of NULLs #9089

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: fix ArrayValue.remove() handling of NULLs #9089

wants to merge 1 commit into from

Conversation

NickCrews
Copy link
Contributor

@NickCrews NickCrews commented Apr 30, 2024 •
edited

ibis.array([1, None, 2]).remove(None) doesn't behave as expected. Still a WIP, figuring out what should be desired.

cpcloud
cpcloud requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the fix here?

What was the original behavior? What's the new behavior? Why is it desired?

Blank PR descriptions make it really difficult to prioritize reviews on behavioral changes, please include them in those types of PRs!

@NickCrews NickCrews marked this pull request as draft June 3, 2024 19:41
@NickCrews
Copy link
Contributor Author

Sorry, this is very much a WIP, should have marked it as such. Added a very basic description to the OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NickCrews @cpcloud