Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for GAE deployment #655

Merged
merged 1 commit into from
May 17, 2021
Merged

Bugfix for GAE deployment #655

merged 1 commit into from
May 17, 2021

Conversation

cewald
Copy link
Contributor

@cewald cewald commented May 17, 2021

Related ticket

TCK-228722

Checklist

  • I've made necessary changes in the configs repository shop-workspace (if needed)
  • I'm aware of depending changes in other repositories

* There is a bug with the latest LTS `14.17.0` during cloud-build for GAE Flex, so fallback to the latest, working version of NodeJS.
* See here: GoogleCloudPlatform/nodejs-docker#214
@cewald cewald merged commit d9f23fb into master May 17, 2021
@cewald cewald deleted the hotfix/node-lts-vs-gae-flex branch May 17, 2021 11:10
cewald added a commit that referenced this pull request May 19, 2021
* There is already an open ticket in the GCP repo
cewald added a commit that referenced this pull request May 19, 2021
* Revert changes from #655, there is already an open ticket in the GCP repo (I've linked it in the previous PR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants