-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next): create svg css sprites #236
Conversation
We'll need to move a few dependencies to dev dependencies to inline I'll try to test both packages using |
"version": "2.1.7", | ||
"license": "MIT", | ||
"bugs": "https://github.com/iconify/iconify/issues", | ||
"homepage": "https://iconify.design/docs/libraries/utils-cli/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to add the entry in docs website
icons: AsyncSpriteIcons | AsyncSpriteIconsFactory, | ||
warn = true | ||
) { | ||
const context: Sprites = { content: '' }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow provide context, maybe we'll need to add icons and mappings.
Update other functions here and in node module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need this, the main problem will be on UnoCSS: when building we'll need to emit the svg sprite (will include a hash) and the css icon url style will need the new sprite name.
chore: add defineConfig chore: add package exports + dts
Converting to draft, adding tests... |
chore: add tests
Closing this PR, see unocss/unocss#2675 (comment) |
supersedes #235