Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): create svg css sprites #236

Closed
wants to merge 24 commits into from

Conversation

userquin
Copy link
Collaborator

@userquin userquin commented Aug 2, 2023

supersedes #235

@userquin userquin changed the title Userquin/feat create svg css sprites feat: create svg css sprites Aug 2, 2023
@userquin userquin changed the base branch from main to next August 2, 2023 18:12
@userquin userquin marked this pull request as ready for review August 3, 2023 12:49
@userquin
Copy link
Collaborator Author

userquin commented Aug 3, 2023

We'll need to move a few dependencies to dev dependencies to inline cac, colorette, consola and unconfig, I guess it is fine.

I'll try to test both packages using pnpm pack and install utils and utils-cli via file: protocol.

"version": "2.1.7",
"license": "MIT",
"bugs": "https://github.com/iconify/iconify/issues",
"homepage": "https://iconify.design/docs/libraries/utils-cli/",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to add the entry in docs website

icons: AsyncSpriteIcons | AsyncSpriteIconsFactory,
warn = true
) {
const context: Sprites = { content: '' };
Copy link
Collaborator Author

@userquin userquin Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow provide context, maybe we'll need to add icons and mappings.

Update other functions here and in node module.

Copy link
Collaborator Author

@userquin userquin Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need this, the main problem will be on UnoCSS: when building we'll need to emit the svg sprite (will include a hash) and the css icon url style will need the new sprite name.

@userquin userquin changed the title feat: create svg css sprites feat(next): create svg css sprites Aug 3, 2023
@userquin
Copy link
Collaborator Author

userquin commented Aug 4, 2023

Converting to draft, adding tests...

@userquin userquin marked this pull request as draft August 4, 2023 10:08
@userquin userquin marked this pull request as ready for review August 4, 2023 12:20
@cyberalien
Copy link
Member

Closing this PR, see unocss/unocss#2675 (comment)

@cyberalien cyberalien closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants