New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDEMPIERE-5875:In grid mode, CSV export (all record) move child tab to last parent row (but still showing before export parent row) #2041
base: master
Are you sure you want to change the base?
Conversation
…o latest (still keep parrent to current) not yet keep selection on detail
hi @hieplq , "not yet keep selection on detail" - that's for future or this ticket is still in progress ? |
…o last parent row (but still showing before export parent row) implement for keep selection on detail
that time i have no idea for implement it. just update PR to implement for detail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comment in ticket
@@ -301,6 +316,19 @@ else if (sValue != null && ! (Boolean) sValue) | |||
} catch (IOException e) { | |||
throw new AdempiereException(e); | |||
} finally { | |||
gridTab.setCurrentRow(currentRow); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps should be gridTab.setCurrentRow(currentRow, true);
instead ?
childTab.initTab(false); | ||
} | ||
childTab.query(false, 0, 0); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need to re-query all child here. It is just export and very unlikely to cause any side effect.
hi @hieplq , any update on this ? |
https://idempiere.atlassian.net/browse/IDEMPIERE-5875
not yet keep selection on detail
Pull Request Checklist
Tests
Documentation