Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-5875:In grid mode, CSV export (all record) move child tab to last parent row (but still showing before export parent row) #2041

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hieplq
Copy link
Contributor

@hieplq hieplq commented Oct 3, 2023

https://idempiere.atlassian.net/browse/IDEMPIERE-5875

not yet keep selection on detail

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

Documentation

  • I have made corresponding changes to the documentation as follows:
    • New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld.
    • Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change.
    • Improvement (improves and existing functionality): This documentation is needed if the improvement changes the way the user interacts with the system or the outcome of a process/task changes. If it is just, for instance, a performance improvement, documentation might not be needed.
  • The changed/added documentation is in the project wiki (not privately-hosted pdf files or links pointing to a company website) and is complete and self-explanatory.

…o latest (still keep parrent to current)

not yet keep selection on detail
@hengsin hengsin changed the title IDEMPIERE-5875:in grid mode, csv export (all record) move child tab to latest (still keep parrent to current) IDEMPIERE-5875:In grid mode, CSV export (all record) move child tab to last parent row (but still showing before export parent row) Oct 3, 2023
@hengsin
Copy link
Collaborator

hengsin commented Oct 3, 2023

hi @hieplq , "not yet keep selection on detail" - that's for future or this ticket is still in progress ?

…o last parent row (but still showing before export parent row)

implement for keep selection on detail
@hieplq
Copy link
Contributor Author

hieplq commented Oct 4, 2023

hi @hieplq , "not yet keep selection on detail" - that's for future or this ticket is still in progress ?

that time i have no idea for implement it. just update PR to implement for detail

Copy link
Collaborator

@hengsin hengsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment in ticket

@@ -301,6 +316,19 @@ else if (sValue != null && ! (Boolean) sValue)
} catch (IOException e) {
throw new AdempiereException(e);
} finally {
gridTab.setCurrentRow(currentRow);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps should be gridTab.setCurrentRow(currentRow, true); instead ?

childTab.initTab(false);
}
childTab.query(false, 0, 0);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need to re-query all child here. It is just export and very unlikely to cause any side effect.

@hengsin
Copy link
Collaborator

hengsin commented May 9, 2024

hi @hieplq , any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants