Add fullscreen error message in browser for compiler errors #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The other option is something more like this:
|
* master: (23 commits) Publish remove unused function clean up comments add test for get datasets update test for getting components make dataset format same as component add note for avoiding index.js slight minor update add exception for index.js don't include .js in component names remove unneeded idyll var use data directory for getting datasets add initial (redundant as component) logic for adding datasets update comments correct upon directory checking for adding component add initial addComponent functionality clean up test update components test use directory info from ComponentResolver add name of default data for datasets method ...
|
It seems there is a bug in browsersync (BrowserSync/browser-sync#538) that will prevent us from using the second option, so we'll need to stick to the first for now. |
|
/cc @joshuahhh |
|
Now I just need to figure out why the tests are failing... |
* master: docs updates Publish more robust property access check fix bug in expression regarding refs and prop access put output extra space after is Publish handle errors in the JS parser add missing dep: update tests fix dev mode fix refs remove reference to deleted module pass userViewComponent from props remove placeholder file Update CHANGELOG.md add initial update to take in optional user defined view component add initial choice between AuthorTool and user defined component change style to use single ticks instead of quotes change tooltip placement to bottom (still TODO) initial add shadow to debug components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #31, this PR adds a fullscreen overlay that displays any errors thrown by the Idyll CLI tool.
Example below: