Support of an unique SMPTE ST 12 Timecode in track header #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retokromer
reviewed
Feb 11, 2023
| 1 | ||
|
|
||
| definition: | ||
| If present, indicates that Block Additional Mapping is not present and that the stored bytes represent the start timcode. |
There was a problem hiding this comment.
nit: timcode > timecode
|
It seems to me you want add two new elements which are a Rational number. Should we first implement the EBML Rational type? |
Would be better, for sure. |
This might be a while. And since there's no agreed technical solution, you should not create such a file for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several container formats, e.g. MXF or QuickTime, don't have SMPTE ST 12 Timecode values per frame, they have a start time code and a frame rate, then other time codes are computed from that.
This PR adds the support of a similar way to store timecodes in Matroska.
As SMPTE ST 12 does not indicate the corresponding frame rate, we provide it in the private data. frame rate num/den is preferred over an integer because we need the precise source (constant) frame rate for computing the corresponding timecode.