Decrease chart.js bytes #1368
Merged
Decrease chart.js bytes #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
reviewed
Feb 19, 2019
| @@ -30,7 +30,6 @@ | |||
| "axios": "^0.18.0", | |||
| "babel-core": "7.0.0-bridge.0", | |||
| "chart.js": "^2.6.0", | |||
| "chartjs": "^0.3.24", | |||
There was a problem hiding this comment.
Great catch! Oh wow, we had that and chart.js 🤔
julianguyen
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Excluded data for unsupported locales, and removed an unused dependency.
More Details
chartjsdependency (typo ofchart.js)Corresponding Issue
Issues
unlocalized charts
We aren't actually configuring the locale for charts: time axis labels are always in English (at least on
/moments: tested in prod, and tested in a container with my changes).chart.js pulls in all the moment.js locales, but only ever uses the builtin English locale data (unless you reconfigure moment.js before using chart.js). They're abandoning time axis labeling altogether, so we'll need to handle labels ourselves:
@julianguyen Has anyone worked on #726?