Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add readme for the migration tool #4144

Merged
merged 14 commits into from
May 16, 2024
Merged

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented May 15, 2024

close #4115

@Pantani Pantani self-assigned this May 15, 2024
@Pantani Pantani enabled auto-merge (squash) May 15, 2024 13:47
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:internal labels May 15, 2024
@Pantani Pantani added the skip-changelog Don't check changelog for new entries label May 15, 2024
Copy link
Contributor

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly nits

ignite/internal/tools/gen-mig-diffs/readme.md Outdated Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Outdated Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Outdated Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Outdated Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Outdated Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Outdated Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Outdated Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Outdated Show resolved Hide resolved
ignite/internal/tools/gen-mig-diffs/readme.md Show resolved Hide resolved
salmad3 and others added 11 commits May 16, 2024 00:33
Co-authored-by: Danny <danny.f.salman@gmail.com>
Co-authored-by: Danny <danny.f.salman@gmail.com>
Co-authored-by: Danny <danny.f.salman@gmail.com>
Co-authored-by: Danny <danny.f.salman@gmail.com>
Co-authored-by: Danny <danny.f.salman@gmail.com>
Co-authored-by: Danny <danny.f.salman@gmail.com>
Co-authored-by: Danny <danny.f.salman@gmail.com>
Co-authored-by: Danny <danny.f.salman@gmail.com>
@Pantani Pantani requested a review from salmad3 May 16, 2024 15:33
@Pantani Pantani merged commit 423dcc4 into main May 16, 2024
46 checks passed
@Pantani Pantani deleted the feat/migration-tool-readme branch May 16, 2024 20:09
julienrbrt pushed a commit that referenced this pull request May 29, 2024
Co-authored-by: Pantani <Pantani>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs skip-changelog Don't check changelog for new entries type:internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a doc for the migrations tools
2 participants