Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gen-mig-doc): fix repo url #4147

Merged
merged 4 commits into from
May 16, 2024
Merged

fix(gen-mig-doc): fix repo url #4147

merged 4 commits into from
May 16, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented May 16, 2024

Description

  • Add the ability to use HTTP, HTTPS, and SSH git URLs;
  • Fix validation issue when we set the source;

@Pantani Pantani self-assigned this May 16, 2024
@Pantani Pantani added the skip-changelog Don't check changelog for new entries label May 16, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:internal labels May 16, 2024
@Pantani Pantani enabled auto-merge (squash) May 16, 2024 00:43
julienrbrt
julienrbrt approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Pantani Pantani merged commit fb5b081 into main May 16, 2024
46 checks passed
@Pantani Pantani deleted the fix/mig-source branch May 16, 2024 15:42
julienrbrt pushed a commit that referenced this pull request May 29, 2024
@Pantani @julienrbrt
fix(gen-mig-doc): fix repo url (#4147)
cdf33ea 
* fix repo url

* remove unused tests

---------

Co-authored-by: Pantani <Pantani>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs skip-changelog Don't check changelog for new entries type:internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pantani @jeronimoalbi @julienrbrt