Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XEP-0070: Verifying HTTP Requests via XMPP support #557

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cmeng-git
Copy link
Contributor

Thank you for your contribution!

Before creating a Pull Request, please make sure to

@cmeng-git cmeng-git changed the base branch from master to 4.4 March 1, 2023 00:04
Copy link
Member

@Flowdalic Flowdalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually do not add new features to stable Smack branches, so please adjust the target branch to master.

Copy link
Member

@Flowdalic Flowdalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review. I think especially the manager design needs to be changed.


private final String id;
private final String method;
private final String url;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private final String url;
private final URI url;

I believe this member should be of type URI.

Copy link
Contributor Author

@cmeng-git cmeng-git Mar 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this variable be handled as a string all the ways. Otherwise need to do extract steps during xml phrase() and in toXML() method.
In aTalk app implementation, the value is used as string in prompting user to accept or reject the auth request. Do not see the need for app to access the URL directly.

@cmeng-git cmeng-git changed the base branch from 4.4 to master March 27, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants