Skip to content

Commit

Permalink
dep: fix UpperBoundsDep check for checker-qual
Browse files Browse the repository at this point in the history
googleapis#939 switch guava from -android to -jre, which replaced the transitive dep checker-compat-qual with checker-qual. This introduced a version conflict between guava's transitive deps and truth's: gauva depends on version 3.8.0 while truth depends on 3.13.0. googleapis#939 tried to workaround the conflict by excluding the transitive dep from truth, but it didnt do it all places. This finishes the workaround.

I'm not convinced that this is the correct way to resolve the dependency conflict, but for now this PR just makes it consistent
  • Loading branch information
igorbernstein2 committed Aug 9, 2021
1 parent 57cddee commit 673b14e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
8 changes: 8 additions & 0 deletions google-cloud-bigtable-emulator/pom.xml
Expand Up @@ -150,6 +150,14 @@
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
<scope>test</scope>
<exclusions>
<!-- TODO: consider a different approach -->
<!-- exclude to resolve conflict with guava -->
<exclusion>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
Expand Down
4 changes: 4 additions & 0 deletions google-cloud-bigtable/pom.xml
Expand Up @@ -235,6 +235,8 @@
<artifactId>truth</artifactId>
<scope>test</scope>
<exclusions>
<!-- TODO: consider a different approach -->
<!-- exclude to resolve conflict with guava -->
<exclusion>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
Expand All @@ -246,6 +248,8 @@
<artifactId>truth-proto-extension</artifactId>
<scope>test</scope>
<exclusions>
<!-- TODO: consider a different approach -->
<!-- exclude to resolve conflict with guava -->
<exclusion>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
Expand Down

0 comments on commit 673b14e

Please sign in to comment.