Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coala configuration file and add script in package.json #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add coala configuration file and add script in package.json #35

wants to merge 3 commits into from

Conversation

rahulrana95
Copy link

@rahulrana95 rahulrana95 commented Oct 1, 2018 •
edited by aashutoshrathi

Fixes #13

Description

You run the linter from terminal by running npm run lint
Make sure you have python >=3.4
A few sentences describing the change

Screenshot Before Change:

Screenshot After Change:

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Non Functional Requirement

  • Follows the code style of this project.
  • Tests Cover Changes
  • I have performed a self-review of my own code
  • All new and existing tests passed.
  • Documentation

aashutoshrathi
aashutoshrathi requested changes Oct 1, 2018
View reviewed changes
.coarc Outdated
@@ -0,0 +1 @@
ignore = node_modules/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashutoshrathi Ok if we want to use coala its fine.I will make the change then you can merge the PR.

@aashutoshrathi
Copy link
Member

aashutoshrathi commented Oct 3, 2018 •
edited

Sure. also resolve conflicts.

@rahulrana95
Copy link
Author

@aashutoshrathi Made the changes. Please approve PR

@aashutoshrathi aashutoshrathi added this to In progress in Basic Setup Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashutoshrathi aashutoshrathi aashutoshrathi requested changes

Assignees
No one assigned
Labels
None yet
Projects
Basic Setup
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a code linter
2 participants
@rahulrana95 @aashutoshrathi