Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes & improvements to Subtitle Chooser #4833

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

svobs
Copy link
Contributor

@svobs svobs commented Feb 24, 2024


Description:
Like #4825 but makes additional changes:

  • The message osd.sub_found, previously set to %d subtitles found. Downloading…, was not exactly appropriate as the heading for the list of subtitles to download. It looks like this is was done because it was being reused for the actual "downloading" message. So I changed the existing message to remove the Downloading… part, and added a new osd.sub_downloading message whose English version is Downloading %d subtitles, and changed the "downloading" message to use this key instead.
  • Improve text size of sub-heading and table items slightly
  • Change table style & border so it looks like this mock-up from @Iiii-I-I-I. Also implemented some other changes to displayed attributes based on said mock-up:
  • Remove time from upload date (seems rare that subtitles are uploaded more than once a day).
  • Remove rating (seems to be 0.0 most of the time?) - am open to bringing this back
  • Add release year in parentheses.
  • Add up to 2 fraction digits to fps attribute's displayed value.

…rred width of 480 to that it doesn't collapse to size of OSD title, fix row item text alignment, fix layout warning
@svobs svobs force-pushed the pr-sub-chooser-improvements branch from 19e644f to 164f8da Compare February 24, 2024 06:47
…ore appropriately specific messages. SubChooseView: fix table border bezel, increase font size slightly and set preferred width to 600. Modify OpenSubtitles details: add release year, remove rating, add max 2 fraction digits to fps, remove time from upload date, increase spacing to make attribute separation more clear
@svobs svobs force-pushed the pr-sub-chooser-improvements branch from 164f8da to 424445f Compare February 24, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant