Fixes & improvements to Subtitle Chooser #4833
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Like #4825 but makes additional changes:
osd.sub_found
, previously set to%d subtitles found. Downloading…
, was not exactly appropriate as the heading for the list of subtitles to download. It looks like this is was done because it was being reused for the actual "downloading" message. So I changed the existing message to remove theDownloading…
part, and added a newosd.sub_downloading
message whose English version isDownloading %d subtitles
, and changed the "downloading" message to use this key instead.fps
attribute's displayed value.