Make all volume icons indicate level #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Add a volumeIcon method to PlayerWindowController that returns the appropriate icon based on volume level - Add an updateVolume method to MainWindowController that sets the icon on the mute button - Change MiniPlayerController.updateVolume to set the icon on the mute button as well as the volume button The mini window selects the image to use for the volume button from multiple images based on the volume level. This commit extends that functionality to the mute button in the main window and the mute button in the mini window. This makes the behavior of volume icons consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
volumeIconmethod toPlayerWindowControllerthat returns the appropriate icon based on volume levelupdateVolumemethod toMainWindowControllerthat sets the icon on the mute buttonMiniPlayerController.updateVolumeto set the icon on the mute button as well as the volume buttonThe mini window selects the image to use for the volume button from multiple images based on the volume level. This commit extends that functionality to the mute button in the main window and the mute button in the mini window. This makes the behavior of volume icons consistent.
Description: