Fix incorrect directionality in RTL OSD. #4884 #4886
Merged
+40
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Add withPosition and withLeftToRightText message types to OSDMessage - Change the seek message type in OSDMessage to use withPosition instead of withProgress - Change the abLoop, abLoopUpdate, chapter, pause and resume message types in OSDMessage to use withLeftToRightText instead of withText - Add support for withPosition to MainWindowController.displayOSD that uses a left to right layout for the text and slider - Add support for withLeftToRightText to MainWindowController.displayOSD that uses a left to right layout for the text This adjusts IINA's behavior to match Apple's guidance that timeline indicators should not flip in a right-to-left language. The updated OSD messages all reference positions within the video.
|
I'm used to messages (toasts) appearing at the "end" of the screen, meaning in English it's usually on the right side. It's like that in macos notifications, in English it's on the right side and in Hebrew it's on the left side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
withPositionandwithLeftToRightTextmessage types toOSDMessageseekmessage type inOSDMessageto usewithPositioninstead ofwithProgressabLoop,abLoopUpdate,chapter,pauseandresumemessage types inOSDMessageto usewithLeftToRightTextinstead ofwithTextwithPositiontoMainWindowController.displayOSDthat uses a left to right layout for the text and sliderwithLeftToRightTexttoMainWindowController.displayOSDthat uses a left to right layout for the textThis adjusts IINA's behavior to match Apple's guidance that timeline indicators should not flip in a right-to-left language. The updated OSD messages all reference positions within the video.
Description: