Fix RTL language causes overlapping in settings, #4888

[low-batt]

This commit will:

• Correct the constraints in PrefSubViewController.xib
• Change the Mirror setting to Never on the color wells in the XIB
• Change the language-direction of the battery icon from Fixed to Left to Right, Mirrors

This corrects a problem with color wells overlapping their labels on the Subtitle tab of IINA's settings. This also changes the battery icon shown in full screen mode to flip in a RTL language correcting another overlapping problem.

• I have read CONTRIBUTING.md
• This implements/fixes issue RTL language causes overlapping in subtitle settings #4888.

---

Description:

[low-batt]

See issue #4776 for a screenshot of the RTL overlaps.

IINA 1.3.4:

With the changes in this PR…

[low-batt]

The issue with the malformed color wells in RTL has been fixed:

But the mirroring applied by AppKit to the battery icon results in a blurry image:

@lhc70000 will be generating a reversed battery image. I will then add it to the existing battery icon image set as a Right to Left image.

I have set this to be a draft until the blurry battery problem is corrected.

[ShlomoCode]

It seems to me that a perfect inversion is like this:

Instead of:

[ShlomoCode]

@lhc70000 will be generating a reversed battery image. I will then add it to the existing battery icon image set as a Right to Left image.

I mirrored the PDF from here simply using Apple Preview, it seems to keep full quality.
battery.pdf

[low-batt]

Thanks! But… been there, done that. It all looked good in Preview and in Xcode, but at runtime the flipped battery looks just like the original battery. It faces the wrong direction. This is because Apple Preview does not remake the PDF, it adds a rotate tag to it. Seems AppKit does not support the tag.

At least I think that is what was happening. Did I miss something?

[ShlomoCode]

Yes, it looks like you're right :(
BTW recreating the file with ImageMagick helps, but I couldn't find the exact command to keep the file at full quality

[low-batt]

Took me a while to figure out what was happening. Since Xcode showed the reversed PDF correctly I was thinking the code was not picking the RTL version of the battery.

@lhc70000 created the battery icon. He will be able to provide a flipped one that matches the existing one.

[ShlomoCode]

@low-batt What do you think about this?

[low-batt]

Oh. I missed that detail. My thoughts are that IINA should not try to change this. This is the behavior Apple supplies for an AppKit NSColorWell. If this is incorrect then Apple needs to fix it. Just to be sure I ran the little test program I wrote while working on this and confirmed this is the Apple supplied RTL behavior for this component.

[lhc70000]

Added the mirrored battery icon.

[low-batt]

Thanks! The new icon looks good. However I am going to simplify the change. There is no need for the code in MainWindowController. The easier way to do this is to reconfigure the icon to select the correct image automatically. I will work on that change now.

[low-batt]

The constraint for the text within the battery icon is correct for LTR and a little off for RTL. I will be fixing that, but gotten too late tonight. I have to help afriend tomorrow, so may not get to it until Saturday. Leaving this as a draft for now.

To get an icon to have separate LTR and RTL images change the direction to Both as I shown below. Once that change is made a location for a RTL image appears and you can just drag & drop the RTL image to it.

[low-batt]

LTR:

RTL:

I think this one is ready for review