Fix sub ass style overrides always applied, #4927 #4928
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Change the subOverrideHandler Transformer in MPVController.mpvInit to return "no" when "Ignore ASS styles" is disabled - Change PrefSubViewController.xib to only enable the "Override level" slider when "Ignore ASS styles" is enabled - Add 20 to the horizontal location of the "Override level" label to indent this setting under the "Ignore ASS styles" setting This changes IINA to set the mpv option "sub-ass-override" to "no" when the setting for overriding styles in Advanced Substation Alpha subtitles is not enabled. This commit also indents the "Override level" setting to indicate it is a subordinate option and disables the slider if "Ignore ASS styles" is not enabled.
1 task
1 task
|
Based on the concerns expressed in this issue comment about the change in behavior this fix causes I am changing this to be a draft. Looking like to fix this requires significantly more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
subOverrideHandlerTransformerinMPVController.mpvInitto returnnowhenIgnore ASS stylesis disabledPrefSubViewController.xibto only enable theOverride levelslider whenIgnore ASS stylesis enabledOverride levellabel to indent this setting under theIgnore ASS stylessettingThis changes IINA to set the mpv option sub-ass-override to
nowhen the setting for overriding styles in Advanced Substation Alpha subtitles is not enabled. This commit also indents theOverride levelsetting to indicate it is a subordinate option and disables the slider ifIgnore ASS stylesis not enabled.Description: