Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using mypy and bandit. #151

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Test using mypy and bandit. #151

wants to merge 2 commits into from

Conversation

schinckel
Copy link
Contributor

mypy does static analysis, and bandit does security auditing (of known
vulnerabilities, and some suspect coding patterns).

Both of these are currently showing some errors, which should be
addressed, and some warnings, which could be addressed.

I'm hoping that travis or whatever is running the tests will pick up this, but I may need to do more.

mypy does static analysis, and bandit does security auditing (of known
vulnerabilities, and some suspect coding patterns).

Both of these are currently showing some errors, which should be
addressed, and some warnings, which could be addressed.
@codecov-io
Copy link

Codecov Report

Merging #151 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #151   +/-   ##
=======================================
  Coverage   52.16%   52.16%           
=======================================
  Files          15       15           
  Lines        1342     1342           
  Branches      137      137           
=======================================
  Hits          700      700           
  Misses        627      627           
  Partials       15       15

@schinckel
Copy link
Contributor Author

schinckel commented Sep 9, 2018

The most pressing issue raised by this is available at https://travis-ci.org/ikalchev/HAP-python/jobs/426333586#L551.

My understanding is that we should be using a different crypto package.

@ikalchev
Copy link
Owner

ikalchev commented Sep 9, 2018

Thanks! I will review this and the raised issues and will open PR to track them later this evening.

Awesome addition

@schinckel
Copy link
Contributor Author

I went to PyConAU a couple of weeks ago, and there was a great talk about using Bandit, and another package (Safety): https://2018.pycon-au.org/talks/43518-watch-out-for-safety-bandits/

It's well worth watching.

@ikalchev
Copy link
Owner

ikalchev commented Sep 9, 2018

I would definitely would like these checks added. However, can we remove them from travis until we address the issues, as otherwise the builds will fail. What do you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants