-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCC13 compatibility: Explicitly include cstdint #72
Open
Blutkoete
wants to merge
1
commit into
ikalnytskyi:master
Choose a base branch
from
Blutkoete:gcc13-compatibility
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
@ikalnytskyi Please merge this PR, it actually is an issue for us, now. termcolor does not work on Ubuntu 23.10 anymore, due to the missing include |
FlorianReimold
added a commit
to eclipse-ecal/ecal
that referenced
this pull request
Oct 26, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold
added a commit
to eclipse-ecal/ecal
that referenced
this pull request
Oct 26, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold
added a commit
to eclipse-ecal/ecal
that referenced
this pull request
Oct 26, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold
added a commit
to eclipse-ecal/ecal
that referenced
this pull request
Oct 26, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold
added a commit
to eclipse-ecal/ecal
that referenced
this pull request
Oct 27, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold
added a commit
to eclipse-ecal/ecal
that referenced
this pull request
Oct 27, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
kz04px
added a commit
to kz04px/cutegames
that referenced
this pull request
Nov 21, 2023
See here: ikalnytskyi/termcolor#72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC13 reduced the amount of implicitly included headers (see https://gcc.gnu.org/gcc-13/porting_to.html). To compile termcolor with GCC13, cstdint now needs to be explicity included.
Explicitly including a header that was included implicitly before should normally not change the behaviour on other platforms or when building with a different compiler, but I can't check them all.