Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC13 compatibility: Explicitly include cstdint #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Blutkoete
Copy link

GCC13 reduced the amount of implicitly included headers (see https://gcc.gnu.org/gcc-13/porting_to.html). To compile termcolor with GCC13, cstdint now needs to be explicity included.

Explicitly including a header that was included implicitly before should normally not change the behaviour on other platforms or when building with a different compiler, but I can't check them all.

@FlorianReimold
Copy link

@ikalnytskyi Please merge this PR, it actually is an issue for us, now. termcolor does not work on Ubuntu 23.10 anymore, due to the missing include

FlorianReimold added a commit to eclipse-ecal/ecal that referenced this pull request Oct 26, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold added a commit to eclipse-ecal/ecal that referenced this pull request Oct 26, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold added a commit to eclipse-ecal/ecal that referenced this pull request Oct 26, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold added a commit to eclipse-ecal/ecal that referenced this pull request Oct 26, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold added a commit to eclipse-ecal/ecal that referenced this pull request Oct 27, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
FlorianReimold added a commit to eclipse-ecal/ecal that referenced this pull request Oct 27, 2023
Currently (2023-10-26) termcolor does not include the cstdint header file, but it is needed for Ubuntu 23.10 / gcc 13.2: ikalnytskyi/termcolor#72
kz04px added a commit to kz04px/cutegames that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants