Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binding.gyp #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update binding.gyp #38

wants to merge 1 commit into from

Conversation

egasimus
Copy link

@egasimus egasimus commented Sep 14, 2021

Node 14.17.5, pnpm 6.14.3, both installed via Nix 2.3.15 on Ubuntu 20.04: node-gyp fails, returning a big pile of warnings, plus this one error:

│ ../src/./tree_sitter_markdown/block_context.cc: In member function ‘tree_sitter_markdown::ParseState tree_sitter_markdown::Bloc                                                                                                                                      
│ ../src/scanner.cc:9:72: error: exception handling disabled, use ‘-fexceptions’ to enable                                                                                                                                                                             
│     9 | #define TREE_SITTER_MARKDOWN_ASSERT(condition) if (!(condition)) throw 1;   

With the attached fix, the build succeeds and tree-sitter-markdown seems to work normally so far.

Based on info from nodejs/node-gyp#17

@VincentCordobes
Copy link

What's the difference with #34 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants