Add TypeScript #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
reviewed
Aug 18, 2019
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "requires": true, | |||
| "lockfileVersion": 1, | |||
There was a problem hiding this comment.
Suggested change
| "lockfileVersion": 1, | |
| "loackerfileVersion": 1, |
ilantc
reviewed
Aug 18, 2019
benjamingr
approved these changes
Aug 18, 2019
ilantc
reviewed
Aug 18, 2019
ArithmeticServer.ts
Outdated
| @@ -18,9 +18,9 @@ http.createServer(function (request, response) { | |||
| ans = 'num must be used with fibonacci pathname!'; | |||
| } | |||
| else { | |||
| n = parseInt(queryData.num); | |||
| let n = parseInt(queryData.num); | |||
There was a problem hiding this comment.
Please define a custom type for n
ilantc
reviewed
Aug 18, 2019
| @@ -18,9 +18,9 @@ http.createServer(function (request, response) { | |||
| ans = 'num must be used with fibonacci pathname!'; | |||
| } | |||
| else { | |||
| n = parseInt(queryData.num); | |||
| let n:number = parseInt(queryData.num); | |||
There was a problem hiding this comment.
Please extract parseInt to a function to better encapsulate how to parse ints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript is an open-source programming language developed and maintained by Microsoft. It is a strict syntactical superset of JavaScript, and adds optional static typing to the language.
Typescript is very robust, and this will really improve the code quality in this repository.