New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finished the Microservice Architecture #2759
Conversation
I think that the automated build is failing because:
You may run |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Closed due to inactivity. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor things before merge, looks good!
<properties> | ||
<maven.compiler.source>17</maven.compiler.source> | ||
<maven.compiler.target>17</maven.compiler.target> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
</properties> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines not needed, they come from the parent
import org.springframework.boot.SpringApplication; | ||
import org.springframework.boot.autoconfigure.SpringBootApplication; | ||
import org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, above the main class, we need to describe the pattern and explain how the code implement it
import org.springframework.stereotype.Service; | ||
|
||
@Service | ||
public class ConsumeService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be ConsumerService
?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Closed due to inactivity. Thank you for your contributions. |
Finished the Microservice Architecture
Pull request description