-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the default theme available by the themeData for tooltips instead… #1464
base: main
Are you sure you want to change the base?
Conversation
… of library's custom theme imaNNeo#1377
@@ -764,7 +762,6 @@ class BarTouchTooltipData with EquatableMixin { | |||
/// Used for equality check, see [EquatableMixin]. | |||
@override | |||
List<Object?> get props => [ | |||
tooltipBgColor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add tooltipThemeData
instead
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 86.54% 86.45% -0.10%
==========================================
Files 45 45
Lines 2996 3005 +9
==========================================
+ Hits 2593 2598 +5
- Misses 403 407 +4
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@@ -3,6 +3,7 @@ | |||
* **BUGFIX** (by @imaNNeo) Fix Negative BarChartRodStackItem are not drawn correctly bug, #1347 | |||
* **BUGFIX** (by @imaNNeo) Fix bar_chart_helper minY calculation bug, #1388 | |||
* **IMPROVEMENT** (by @imaNNeo) Consider fraction digits when formatting chart side titles, #1267 | |||
* **IMPROVEMENT** (by @devilk10) Use the default theme available by the themeData for tooltips instead of color params #1464 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add this line in the new version tag, for example create a ## newVersion
section and add your changelog there
(Please read the contributing guideline carefully.
… of library's custom theme #1377