Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fa b/dev #614

Open
wants to merge 13 commits into
base: legacy
Choose a base branch
from
Open

Fa b/dev #614

wants to merge 13 commits into from

Conversation

Fa-b
Copy link
Contributor

@Fa-b Fa-b commented Oct 11, 2022

fix color option for paintPolygon & paint Polyline
add default color to pad and fix test accordingly
add tests for rgb image to pad
fix missing position data after cropping binary image
adjust image position to negative direction after padding

No additional test are failing by these changes, so my guess is that the position information is not really needed internally?
My thought was to keep the positions after a transformation relative to the parent, which helps when drawing them atop each other.
Obviously negative positions as for after a padding transformation seems strange. But is it wrong?

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 84.43% // Head: 84.55% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (a0ddf46) compared to base (e3ba8d4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           legacy     #614      +/-   ##
==========================================
+ Coverage   84.43%   84.55%   +0.12%     
==========================================
  Files         163      163              
  Lines        5697     5735      +38     
  Branches     1424     1448      +24     
==========================================
+ Hits         4810     4849      +39     
+ Misses        790      789       -1     
  Partials       97       97              
Impacted Files Coverage Δ
src/image/transform/crop.js 100.00% <ø> (ø)
src/image/Image.js 94.50% <100.00%> (+0.18%) ⬆️
src/image/internal/copy.js 100.00% <100.00%> (ø)
src/image/operator/paintPolygon.js 100.00% <100.00%> (ø)
src/image/operator/paintPolyline.js 100.00% <100.00%> (ø)
src/image/transform/pad.js 100.00% <100.00%> (+2.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

added niche fix for cases where binary image init data contains set bits out of boundaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant