-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fa b/dev #614
base: legacy
Are you sure you want to change the base?
Fa b/dev #614
Conversation
… crop processable check (announced process was 'max')
fix color option for paintPolygon & paint Polyline add default color to pad and fix test accordingly add tests for rgb image to pad fix missing position data after cropping binary image
Codecov ReportBase: 84.43% // Head: 84.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## legacy #614 +/- ##
==========================================
+ Coverage 84.43% 84.55% +0.12%
==========================================
Files 163 163
Lines 5697 5735 +38
Branches 1424 1448 +24
==========================================
+ Hits 4810 4849 +39
+ Misses 790 789 -1
Partials 97 97
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added niche fix for cases where binary image init data contains set bits out of boundaries
fix color option for paintPolygon & paint Polyline
add default color to pad and fix test accordingly
add tests for rgb image to pad
fix missing position data after cropping binary image
adjust image position to negative direction after padding
No additional test are failing by these changes, so my guess is that the position information is not really needed internally?
My thought was to keep the positions after a transformation relative to the parent, which helps when drawing them atop each other.
Obviously negative positions as for after a padding transformation seems strange. But is it wrong?