-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade zune-jpeg #2198
base: main
Are you sure you want to change the base?
Upgrade zune-jpeg #2198
Conversation
You need to use ZCursors rather than Cursor from what I can tell, did some testing and when decoding images with your implementation on an all black image and saw gray pixels randomly come up (they may have been new pixels), to look at an example of how I made it work (probably has some unnecessary code): main...Murad-Awad:image:upgrade-zune |
I also tested out a version that is functionally the same as yours outside of setting the color + limits params properly (although limits is probably not needed at all given how it is initialized) + using ZCursor: main...Murad-Awad:image:mawad/keep-testing-zune |
@Murad-Awad could you file an issue against the upstream zune-jpeg crate? My understanding is that this version without ZCursor is expected to decode JPEGs properly, so if you are seeing some that get corrupted, they'll want to know |
will do! |
Currently targets
0.5.0-rc0
, will switch to the full0.5.0
release once it comes out