Migrate to Buffer.alloc

close #114
image-size · Nov 14, 2018 · 6652495 · 6652495
1 parent 78f655b
commit 6652495
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -55,7 +55,7 @@ function asyncFileToBuffer (filepath, callback) {
         return callback(new Error('File size is not greater than 0 —— ' + filepath));
       }
       var bufferSize = Math.min(size, MaxBufferSize);
-      var buffer = new Buffer(bufferSize);
+      var buffer = Buffer.alloc(bufferSize);
       // read first buffer block from the file, asynchronously
       fs.read(descriptor, buffer, 0, bufferSize, 0, function (err) {
         if (err) { return callback(err); }
@@ -79,7 +79,7 @@ function syncFileToBuffer (filepath) {
   var descriptor = fs.openSync(filepath, 'r');
   var size = fs.fstatSync(descriptor).size;
   var bufferSize = Math.min(size, MaxBufferSize);
-  var buffer = new Buffer(bufferSize);
+  var buffer = Buffer.alloc(bufferSize);
   fs.readSync(descriptor, buffer, 0, bufferSize, 0);
   fs.closeSync(descriptor);
   return buffer;

diff --git a/lib/types/tiff.js b/lib/types/tiff.js
@@ -24,7 +24,7 @@ function readIFD (buffer, filepath, isBigEndian) {
   }
 
   // populate the buffer
-  var endBuffer = new Buffer(bufferSize);
+  var endBuffer = Buffer.alloc(bufferSize);
   var descriptor = fs.openSync(filepath, 'r');
   fs.readSync(descriptor, endBuffer, 0, bufferSize, ifdOffset);
 

diff --git a/specs/fs-close.spec.js b/specs/fs-close.spec.js
@@ -8,7 +8,7 @@ var imageSize = require('..');
 
 describe('after done reading from files', function () {
   function readFromClosed (descriptor) {
-    fs.readSync(descriptor, new Buffer(1), 0, 1, 0);
+    fs.readSync(descriptor, Buffer.alloc(1), 0, 1, 0);
   }
 
   describe('should close the file descriptor', function () {

diff --git a/specs/others.spec.js b/specs/others.spec.js
@@ -34,7 +34,7 @@ describe('Invalid invocation', function () {
       var bufferSize = 2048;
       var file = 'specs/images/valid/tiff/little-endian.tiff';
 
-      buffer = new Buffer(bufferSize);
+      buffer = Buffer.alloc(bufferSize);
       var filepath = path.resolve(file);
       var descriptor = fs.openSync(filepath, 'r');
       fs.readSync(descriptor, buffer, 0, bufferSize, 0);

diff --git a/specs/valid.spec.js b/specs/valid.spec.js
@@ -105,7 +105,7 @@ describe('Valid images', function () {
 
       beforeEach(function (done) {
 
-        var buffer = new Buffer(bufferSize);
+        var buffer = Buffer.alloc(bufferSize);
         var filepath = path.resolve(file);
         var descriptor = fs.openSync(filepath, 'r');
         fs.readSync(descriptor, buffer, 0, bufferSize, 0);