Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0 #370

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

2.0 #370

wants to merge 18 commits into from

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 31, 2022 •
edited

  • ESM support
  • Browser support

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wong2
Copy link

wong2 commented Oct 18, 2022

Any progress?

@netroy
Copy link
Member Author

netroy commented Oct 18, 2022

@wong2 there is currently no deadline set for this.
If you want to use the Uint8Array change, I could publish an alpha version to npm.

@Princesseuh
Copy link

Princesseuh commented Mar 15, 2023 •
edited

Hello! I'm Erika, from the Astro team.

We depend on image-size since recently, but we've unfortunately run into a fair amount of issues due to the CJS nature of the package. (One day we'll be free from the CJS vs ESM madness, I hope 😔)

We'd love to help getting this PR over the line if you're open to contributions! Just let us know if there's any specific way you'd want us to help and we'll get it done.

@image-size image-size deleted a comment from github-advanced-security bot Mar 29, 2023
@image-size image-size deleted a comment from sonarcloud bot Mar 29, 2023
wereHamster
wereHamster reviewed Apr 13, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@netroy netroy force-pushed the 2.0 branch 4 times, most recently from a54bc28 to f475974 Compare May 30, 2023 11:58
@samypr100 samypr100 mentioned this pull request Jun 12, 2023
Closed
@duncanmak duncanmak mentioned this pull request Jun 27, 2023
Open
@samypr100 @mcdenhoed @netroy
feat: initial browser support (#385)
d40cdc0 
refactor: split out index into separate files for easier node and browser support
tests: make sure tests pass again
chore: use node: style imports
breaking: removed fs support on types/interface.ts
build: adjusted exports to work with node and node16 resolution modes
style: adjusted prettier quotes to match eslint

Co-authored-by: mcdenhoed <mcdenhoed@users.noreply.github.com>
@netroy netroy marked this pull request as ready for review November 13, 2023 21:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netroy
Copy link
Member Author

netroy commented Nov 13, 2023

Published 2.0.0-beta.1 to NPM.
Once I've confirmed that this works with browsers as expected, will publish 2.0.0 as the latest.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@OliverSpeir
Copy link

I think there might be some issue with Directory import not supported resolving ES modules errors related to the current set up. Would it be worth considering using babel to create the two seperate distributions (dist/esm and dist/cjs)?

I think this way the source .ts files can use file extensions

@stefansundin stefansundin mentioned this pull request Mar 8, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wereHamster wereHamster wereHamster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@netroy @wong2 @Princesseuh @OliverSpeir @wereHamster @samypr100 @mcdenhoed