Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up svg detection #404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Speed up svg detection #404

wants to merge 1 commit into from

Conversation

Its-Just-Nans
Copy link

@Its-Just-Nans Its-Just-Nans commented May 1, 2024 •
edited

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

netroy
netroy reviewed May 1, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all this does is potentially speed up svg detection, and definitely not add svg detection.
also, I don't think this actually fixes any of the linked issues.
Did you test this change with the reported svg files?

@Its-Just-Nans
Copy link
Author

The major problems was with an incorrect dimensions.

I've added a cleaner error message in astro

infos: withastro/astro#10924 (comment)

@Its-Just-Nans Its-Just-Nans changed the title Add svg detection Speed up svg detection May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Its-Just-Nans @netroy