Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribeall argument bug #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

subscribeall argument bug #233

wants to merge 1 commit into from

Conversation

iamdue
Copy link

@iamdue iamdue commented Sep 4, 2020

There was a bug when using subscribeall and subfolder2 args together. The parent(subfolder2) was not subscribed, only the children folders. So I created "sub" called subscribe to folder, which is called after a folder is created and subscribe is neccessary..

…_old, also removed subscribe from FOLDER method
@gilleslamiral
Copy link
Member

Thanks!
I'll integrate your patch upstream

Copy link
Member

@gilleslamiral gilleslamiral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to subscribe has also to be made where it used to be since subscribed folders synchronization is something independent of folder creation. You want to subscribe folders even if they already exist.
(maybe I misread your patch, tell me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants