Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-389-1][PE-1517] chore: remove the domain prop #51

Merged
merged 25 commits into from
Nov 2, 2021
Merged

[PE-389-1][PE-1517] chore: remove the domain prop #51

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b3049cd
chore: remove the domain prop
luqven Oct 28, 2021
68f8eca
feat: create a search service endpoint
luqven Oct 28, 2021
e784009
chore: add on submit and change handlers
luqven Oct 28, 2021
abb1855
feat: add serach to asset browser
luqven Oct 28, 2021
28c1c5d
chore: change searchbar story props
luqven Oct 28, 2021
f66cc1c
chore: make search bar input width larger
luqven Oct 28, 2021
7c2b46d
chore: catch invalid api key errors
luqven Oct 28, 2021
dd17070
chore: change spinner color
luqven Oct 28, 2021
412062e
feat: display API warnings in asset browser
luqven Oct 28, 2021
d02a0e3
chore: add asset grid story placeholder prop
luqven Oct 28, 2021
66983b1
chore: create and export the cursor type
luqven Oct 28, 2021
67cd3e3
feat: create the pagination component
luqven Oct 28, 2021
30dde96
feat(imgix-api): store response cursor object
luqven Oct 28, 2021
0743306
refactor: lift asset-browser state into container
luqven Oct 28, 2021
018a110
refactor(asset-grid): render placeholder
luqven Oct 28, 2021
2ec1f53
feat: create asset browsner container
luqven Oct 28, 2021
2f75ae3
chore: update story props for asset grid & browser
luqven Oct 28, 2021
74ff793
chore: add todo
luqven Oct 28, 2021
bf4d1a5
chore: remove unused border
luqven Oct 28, 2021
769fc90
feat(asset-browser): add pagination
luqven Oct 28, 2021
095b514
chore: update grid style to show more assets
luqven Oct 28, 2021
1cfcfc2
chore: update jsdoc to use params tag
luqven Nov 2, 2021
f105d10
chore: remove console log
luqven Nov 2, 2021
0dbe72a
chore: replace any type with source type
luqven Nov 2, 2021
6c6e47d
chore: add more meaningful api key error message
luqven Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions frontend/src/components/grids/AssetGrid.tsx
View file
Open in desktop
Expand Up @@ -14,8 +14,7 @@ export function AssetGrid({ assets, domain }: Props): ReactElement {
<div className="ix-grid-item" key={`${asset.id}-${idx}`}>
<div className="ix-grid-item-image">
<Imgix
domain={domain}
src={asset.attributes.origin_path}
src={"https://" + domain + asset.attributes.origin_path}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume so, but just checking: does asset.attributes.origin_path always start with a /?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK yes. I've yet to run into an instance where that's not the case. We might want to "normalize" these paths in future to play it safe.

width={340}
height={340}
imgixParams={{
Expand Down