Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javascript example for truncated signature #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koenpunt
Copy link
Contributor

@koenpunt koenpunt commented May 25, 2019

Since some of the other examples also demonstrate the use truncated signatures, I've added it for the javascript example.

@koenpunt koenpunt marked this pull request as ready for review May 25, 2019 17:45
@DarthSim
Copy link
Member

Hi,

Thanks for your contribution! Could you put the truncated signature example in a separate file so it won't puzzle ones who don't need truncation?

@koenpunt
Copy link
Contributor Author

Could you put the truncated signature example in a separate file

Ha, I saw a similar comment on the PHP version after I submitted this PR, so I was already expecting this feedback. Although I think in this case it's a bit different, since it's just a simple slice on the digest value, whereas with the PHP version there's a new method call introduced.

But if you really want to me to split it I can do that as well.

@DarthSim
Copy link
Member

I like examples to be copy-paste ready with as less redundant code as possible. So let's split it :)

@koenpunt koenpunt changed the title add signature size option to javascript example Add javascript example for truncated signature May 19, 2024
@koenpunt
Copy link
Contributor Author

Took me some time, but I updated this PR to have the example in a separate file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants