Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immer 7 doesn't work with Hermes engine #626

Closed
mweststrate opened this issue Jun 19, 2020 · 3 comments
Closed

Immer 7 doesn't work with Hermes engine #626

mweststrate opened this issue Jun 19, 2020 · 3 comments
Labels
released work in progress

Comments

@mweststrate
Copy link
Collaborator

馃悰 Bug Report

I have this issue in react-native with immer v7 and hermes enabled (the issue only happens with hermes enabled).

Steps to reproduce:

  • Clone this repo
  • Run project (yarn android or yarn ios)
  • In the welcome screen touch the number

Immer v6 works with hermes.
You can change to immer v6 in these lines:

Originally posted by @ahce in #425 (comment)
@mweststrate
Copy link
Collaborator Author

cc @elkinjosetm

@mweststrate
Copy link
Collaborator Author

It looks like Object.getOwnPropertyDescriptors is not available in Hermes:

Screen Shot 2020-06-19 at 16 31 29

@mweststrate mweststrate mentioned this issue Jun 19, 2020
Closed
@aleclarson
Copy link
Member

馃帀 This issue has been resolved in version 7.0.3 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@likern likern mentioned this issue Nov 5, 2020
Closed
@ahce ahce mentioned this issue May 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweststrate @aleclarson