clear Map produces incorrect patches

[LYF1999]

🐛 Bug Report

clear Map produce incorrect patches

Link to repro

codebox link: https://codesandbox.io/s/immer-sandbox-forked-zz8le

immer source code

immer/src/plugins/mapset.ts

Line 112 in bf90358

state.assigned_ = new Map()

this line clears the assigned_, and Patch Plugin gen patches depends on each(state.assigned_)

immer/src/plugins/patches.ts

Lines 121 to 143 in bf90358

	function generatePatchesFromAssigned(
	state: MapState | ES5ObjectState | ProxyObjectState,
	basePath: PatchPath,
	patches: Patch[],
	inversePatches: Patch[]
	) {
	const {base_, copy_} = state
	each(state.assigned_!, (key, assignedValue) => {
	const origValue = get(base_, key)
	const value = get(copy_!, key)
	const op = !assignedValue ? REMOVE : has(base_, key) ? REPLACE : ADD
	if (origValue === value && op === REPLACE) return
	const path = basePath.concat(key as any)
	patches.push(op === REMOVE ? {op, path} : {op, path, value})
	inversePatches.push(
	op === ADD
	? {op: REMOVE, path}
	: op === REMOVE
	? {op: ADD, path, value: clonePatchValueIfNeeded(origValue)}
	: {op: REPLACE, path, value: clonePatchValueIfNeeded(origValue)}
	)
	})
	}

is this by design? or a bug.

To Reproduce

just run the codesanbox link above

Observed behavior

changes is a empty array.

Expected behavior

changes is [{ type: 'Remove', path: ['t2', 't'] }]

Environment

We only accept bug reports against the latest Immer version.

• Immer version:
• I filed this report against the latest version of Immer
• Occurs with setUseProxies(true)
• Occurs with setUseProxies(false) (ES5 only)

[mweststrate]

Looks like a bug indeed, PR welcome!

[LYF1999]

OK, I will submit a PR later.

[aleclarson]

🎉 This issue has been resolved in version 7.0.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀