Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set assigned keys when clear map #664

Merged
merged 1 commit into from
Sep 9, 2020
Merged

set assigned keys when clear map #664

merged 1 commit into from
Sep 9, 2020

Conversation

LYF1999
Copy link
Contributor

@LYF1999 LYF1999 commented Sep 2, 2020

fix #663

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 2, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08f72a0:

Sandbox Source
Immer sandbox Configuration
Immer sandbox (forked) Issue #663

mweststrate
mweststrate approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and thanks for adding a test as well! Left a small NIT

src/plugins/mapset.ts Outdated Show resolved Hide resolved
@LYF1999
Copy link
Contributor Author

LYF1999 commented Sep 7, 2020

hello, is there any other problem about this PR?

@mweststrate mweststrate merged commit bacc1e0 into immerjs:master Sep 9, 2020
@aleclarson
Copy link
Member

🎉 This PR is included in version 7.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweststrate mweststrate mweststrate approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clear Map produces incorrect patches
3 participants
@LYF1999 @aleclarson @mweststrate