Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: In development mode, any new value stored in a tree will be deeply frozen #417

Merged
merged 3 commits into from
Sep 11, 2019

Conversation

mweststrate
Copy link
Collaborator

@mweststrate mweststrate commented Sep 10, 2019

@ianstormtaylor
Copy link
Contributor

ianstormtaylor commented Sep 10, 2019

Just wanted to say that this is awesome, thank you @mweststrate!

src/common.js Outdated Show resolved Hide resolved
src/immer.js Show resolved Hide resolved
src/immer.js Outdated Show resolved Hide resolved
@mweststrate mweststrate merged commit 9fa2581 into master Sep 11, 2019
@mweststrate
Copy link
Collaborator Author

Jeez is semantic release so fragile. This didn't trigger a release, can't really see why....

mweststrate added a commit that referenced this pull request Sep 11, 2019
…will be deeply frozen

This introduces a new side effect, where any data returned for a producer will be frozen. See #417 and linked issues for details
@mweststrate
Copy link
Collaborator Author

@aleclarson how to trigger a major release? I followed the manual, but it doesn't recognize the commit? Any ideas?

@mweststrate
Copy link
Collaborator Author

wow, that was burried deep

@aleclarson
Copy link
Member

You have to put BREAKING CHANGE at the end of the commit body

@mweststrate
Copy link
Collaborator Author

jeez, I guess my screen contrast is not high enough to deduct that from their readme ... :/

mweststrate added a commit that referenced this pull request Sep 11, 2019
…ply frozen.

BREAKING CHANGE: any value returned from produce will be deeply frozen in DEV, even when it wasn't frozen before the producer started. Fixes #412 #363 #260 #230 #313 #229 through #417
@aleclarson
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants