Make explicit use of TypeScript's ReadonlySet and ReadonlyMap types. Fixes #494. #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossop
changed the title
…ixes immerjs#494. TypeScript provides the ReadonlySet and ReadonlyMap types which match their normal counterparts but without any methods that mutate their data. This change makes Immutable<Map> and Immutable<Set> map to those types directly. Worth noting that Map extends ReadonlyMap so we only need to check for one to know what the resulting type is, the same goes for Set and ReadonlySet. This also removes the intermediate Set/Map types since TypeScript no longer seems to need those (likely since TypeScript 3.7, see immerjs#448).
|
Thanks for this PR! Merged into #506 and will become part of the next minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript provides the ReadonlySet and ReadonlyMap types which match
their normal counterparts but without any methods that mutate their data.
This change makes Immutable and Immutable map to those types
directly.
Worth noting that Map extends ReadonlyMap so we only need to check for
one to know what the resulting type is, the same goes for Set and
ReadonlySet.
This also removes the intermediate Set/Map types since TypeScript no
longer seems to need those (likely since TypeScript 3.7, see #448).