Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved types for TypeScript 3.7 #506

Merged
merged 10 commits into from
Jan 14, 2020
Merged

Improved types for TypeScript 3.7 #506

merged 10 commits into from
Jan 14, 2020

Commits on Jan 3, 2020

  1. Make explicit use of TypeScript's ReadonlySet and ReadonlyMap types. F…

    …ixes #494.
    
    TypeScript provides the ReadonlySet and ReadonlyMap types which match
    their normal counterparts but without any methods that mutate their data.
    This change makes Immutable<Map> and Immutable<Set> map to those types
    directly.
    
    Worth noting that Map extends ReadonlyMap so we only need to check for
    one to know what the resulting type is, the same goes for Set and
    ReadonlySet.
    
    This also removes the intermediate Set/Map types since TypeScript no
    longer seems to need those (likely since TypeScript 3.7, see #448).
    Mossop committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    2fba3f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cdc50a9 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. splitted types

    mweststrate committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    71f67e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4204af5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d27f33 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3711dec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b658851 View commit details
    Browse the repository at this point in the history
  6. Added test to verify #461

    mweststrate committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    fdf4be6 View commit details
    Browse the repository at this point in the history
  7. Fixed some test issues

    mweststrate committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    9081634 View commit details
    Browse the repository at this point in the history
  8. Fixed another build issue

    mweststrate committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    69cbf56 View commit details
    Browse the repository at this point in the history