-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved types for TypeScript 3.7 #506
Merged
Merged
Commits on Jan 3, 2020
-
Make explicit use of TypeScript's ReadonlySet and ReadonlyMap types. F…
…ixes #494. TypeScript provides the ReadonlySet and ReadonlyMap types which match their normal counterparts but without any methods that mutate their data. This change makes Immutable<Map> and Immutable<Set> map to those types directly. Worth noting that Map extends ReadonlyMap so we only need to check for one to know what the resulting type is, the same goes for Set and ReadonlySet. This also removes the intermediate Set/Map types since TypeScript no longer seems to need those (likely since TypeScript 3.7, see #448).
Configuration menu - View commit details
-
Copy full SHA for 2fba3f8 - Browse repository at this point
Copy the full SHA 2fba3f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdc50a9 - Browse repository at this point
Copy the full SHA cdc50a9View commit details
Commits on Jan 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 71f67e5 - Browse repository at this point
Copy the full SHA 71f67e5View commit details -
Merge branch 'readonly_types' of https://github.com/Mossop/immer into…
… improved-types
Configuration menu - View commit details
-
Copy full SHA for 4204af5 - Browse repository at this point
Copy the full SHA 4204af5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d27f33 - Browse repository at this point
Copy the full SHA 2d27f33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3711dec - Browse repository at this point
Copy the full SHA 3711decView commit details -
Configuration menu - View commit details
-
Copy full SHA for b658851 - Browse repository at this point
Copy the full SHA b658851View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdf4be6 - Browse repository at this point
Copy the full SHA fdf4be6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9081634 - Browse repository at this point
Copy the full SHA 9081634View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69cbf56 - Browse repository at this point
Copy the full SHA 69cbf56View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.