-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docs guides backup-script #9275
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! My personal opinion is that we should keep the initialization logic out of the daily script like it was before, as this is more likely to conceal errors than help prevent them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot more robust, thank you.
Thank you for improving the script!
Can you mention that the first time this script is run, it should be run as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes to the script to include a helper section, looks good to me now except I got a syntax error that I commented on above. Also looks like the formatter checks are failing.
Description
fix docs guides backup-script
don't repeat script
Fixes # (issue)
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: