feat(server): album's email notification #9439
Merged
+580
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
c895362
|
| Status: | ⚡️ Build in progress... |
…album-update-email
…album-update-email
jrasm91
reviewed
May 16, 2024
…album-update-email
…album-update-email
bo0tzz
reviewed
May 16, 2024
Comment on lines
161
to
182
| const { html, text } = this.notificationRepository.renderEmail({ | ||
| template: EmailTemplate.ALBUM_UPDATE, | ||
| data: { | ||
| baseUrl: server.externalDomain || 'http://localhost:2283', | ||
| albumId: album.id, | ||
| albumName: album.albumName, | ||
| recipientName: recipient.name, | ||
| cid: attachement ? attachement.cid : undefined, | ||
| }, | ||
| }); | ||
|
|
||
| await this.jobRepository.queue({ | ||
| name: JobName.SEND_EMAIL, | ||
| data: { | ||
| to: recipient.email, | ||
| subject: `New media have been added to an album - ${album.albumName}`, | ||
| html, | ||
| text, | ||
| imageAttachements: attachement ? [attachement] : undefined, | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
We can probably pull this out into a shared sendEmail func
Co-authored-by: bo0tzz <git@bo0tzz.me>
Co-authored-by: bo0tzz <git@bo0tzz.me>
jrasm91
reviewed
May 16, 2024
jrasm91
reviewed
May 16, 2024
jrasm91
reviewed
May 16, 2024
jrasm91
approved these changes
May 16, 2024
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
zackpollard
approved these changes
May 24, 2024
Co-authored-by: Zack Pollard <zackpollard@ymail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds email notifications for albums when