BREAKING: KeyedCollection.toArray() returns array of tuples. #1340
+60
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a long standing API quirk where `x.toArray()` had different behavior from `[...x]` or `Array.from(x)`. This is breaking since previously Map, and other keyed collections would provide an array of only values from `.toArray()`, to fix code that relies on this behavior, convert `x.toArray()` to `x.valueSeq().toArray()`. Likewise, for code that was working around this behavior before, `x.entrySeq().toArray()` can typically be replaced with `x.toArray()`. Fixes #333
acusti
added a commit
to brandcast/draft-js
that referenced
this pull request
Oct 14, 2017
Immutable v4 Introduces a number of breaking changes, but the only one that seems to affect draft is that calling toArray on Keyed collections, like Map, now returns [key, value] tuples instead of just an array of values: immutable-js/immutable-js#1340
|
Thank you for your great efforts on a great library. I'm trying out version 4 and it's great. Just wanted to give you a heads-up on the new toArray() behaviour. I bit me in several places in my code base. I think this one needs to be shout out properly in the documentation. A common place for my use of toArray() is in ReduxSaga when I'm forking tasks based on data in Immutable.Map. |
faustbrian
added a commit
to ArkEcosystem/core
that referenced
this pull request
Nov 9, 2018
spkjp
pushed a commit
to ArkEcosystem/core
that referenced
this pull request
Nov 9, 2018
* chore: update dependencies * fix(core-test-utils): adjust blockchain entry helper to xstate v4 * fix(core-blockchain): replace toArray calls with valueSeq.toArray on OrderedMaps See immutable-js/immutable-js#1340 and https://github.com/facebook/immutable-js/releases/tag/v4.0.0-rc.5 for more details * chore: update yarn.lock
acusti
added a commit
to acusti/draft-js
that referenced
this pull request
May 21, 2021
one of the breaking changes in immutable 4.x.x is that KeyedCollection.toArray() now returns an array of [k, v] tuples, instead of just an array of the values: immutable-js/immutable-js#1340
This was referenced May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long standing API quirk where
x.toArray()had different behavior from[...x]orArray.from(x).This is breaking since previously Map, and other keyed collections would provide an array of only values from
.toArray(), to fix code that relies on this behavior, convertx.toArray()tox.valueSeq().toArray().Likewise, for code that was working around this behavior before,
x.entrySeq().toArray()can typically be replaced withx.toArray().Fixes #333